Re: [PATCH V7 2/4] cpufreq: amd-pstate: Add test module for amd-pstate driver
From: Shuah Khan
Date: Wed May 25 2022 - 12:05:33 EST
On 5/22/22 5:54 AM, Meng Li wrote:
Add amd-pstate-ut module, which is conceptually out-of-tree module
I didn't notice this before. Let's get rid of "out-of-tree" workding.
and provides ways for selftests/amd-pstate driver to test various
kernel module-related functionality. This module will be expected by
some of selftests to be present and loaded.
What does "various kernel module-related functionality" mean. Can we
rephrase this to say "this module is used by kselftest to unit test
amd-pstate functionality" ?
Signed-off-by: Meng Li <li.meng@xxxxxxx>
Acked-by: Huang Rui <ray.huang@xxxxxxx>
---
[snip]
+
+module_init(amd_pstate_ut_init);
+module_exit(amd_pstate_ut_exit);
+
+MODULE_AUTHOR("Meng Li <li.meng@xxxxxxx>");
+MODULE_DESCRIPTION("Kselftest for AMD P-state driver");
Change this to "AMD P-state driver Test module"
Having Kselftest in the name is confusing. It is a test driver
that kselftest amd_pstate_test depends on.
+MODULE_LICENSE("GPL");
With these above changes:
Reviewed-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>
thanks,
-- Shuah