[PATCH 4/4] Input: adp5588-keys - do not explicitly set device as wakeup source
From: Dmitry Torokhov
Date: Sat May 28 2022 - 00:57:13 EST
I2C core will set up device as a wakeup source and will configure interrupt
as a wakeup interrupt if client is created with I2C_CLIENT_WAKE flag. Let's
rely on this facility and to not unconditionally set up the device as
wakeup device in the driver.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
---
drivers/input/keyboard/adp5588-keys.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/input/keyboard/adp5588-keys.c b/drivers/input/keyboard/adp5588-keys.c
index df84a2998ed2..2a274240facb 100644
--- a/drivers/input/keyboard/adp5588-keys.c
+++ b/drivers/input/keyboard/adp5588-keys.c
@@ -589,8 +589,6 @@ static int adp5588_probe(struct i2c_client *client,
if (error)
return error;
- device_init_wakeup(&client->dev, 1);
-
dev_info(&client->dev, "Rev.%d keypad, irq %d\n", revid, client->irq);
return 0;
}
@@ -609,9 +607,6 @@ static int __maybe_unused adp5588_suspend(struct device *dev)
disable_irq(client->irq);
- if (device_may_wakeup(&client->dev))
- enable_irq_wake(client->irq);
-
return 0;
}
@@ -619,9 +614,6 @@ static int __maybe_unused adp5588_resume(struct device *dev)
{
struct i2c_client *client = to_i2c_client(dev);
- if (device_may_wakeup(&client->dev))
- disable_irq_wake(client->irq);
-
enable_irq(client->irq);
return 0;
--
2.36.1.124.g0e6072fb45-goog