Re: [PATCH 2/2] pinctrl: qcom: sc7280: Add lpi pinctrl variant data structure for adsp based targets

[Srinivasa Rao Mandadapu]

On 5/16/2022 8:47 PM, Bjorn Andersson wrote:
Thanks for Your time Bjorn!!!
> On Wed 04 May 06:56 PDT 2022, Srinivasa Rao Mandadapu wrote:
>
> > Add compatible string and lpi pinctrl variant data structure for adsp enabled
> > sc7280 platforms.
> This says what the change does, but gives no clue to what this
> compatible represents and why the clock is not optional.
>
> Could you please describe here what scenario this compatible is to be
> used for etc, so that when someone else adds support for the next
> platform they can use the git history to understand which case to
> follow.
>
> Thanks,
> Bjorn
Okay. Will update the commit message.
> > Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@xxxxxxxxxxx>
> > Co-developed-by: Venkata Prasad Potturu <quic_potturu@xxxxxxxxxxx>
> > Signed-off-by: Venkata Prasad Potturu <quic_potturu@xxxxxxxxxxx>
> > ---
> >   drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c | 14 ++++++++++++++
> >   1 file changed, 14 insertions(+)
> >
> > diff --git a/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c
> > index 2add9a4..c9e85d9 100644
> > --- a/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c
> > +++ b/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c
> > @@ -134,6 +134,16 @@ static const struct lpi_function sc7280_functions[] = {
> >   	LPI_FUNCTION(wsa_swr_data),
> >   };
> >   
> > +static const struct lpi_pinctrl_variant_data sc7280_adsp_lpi_data = {
> > +	.pins = sc7280_lpi_pins,
> > +	.npins = ARRAY_SIZE(sc7280_lpi_pins),
> > +	.groups = sc7280_groups,
> > +	.ngroups = ARRAY_SIZE(sc7280_groups),
> > +	.functions = sc7280_functions,
> > +	.nfunctions = ARRAY_SIZE(sc7280_functions),
> > +	.is_clk_optional = false,
> > +};
> > +
> >   static const struct lpi_pinctrl_variant_data sc7280_lpi_data = {
> >   	.pins = sc7280_lpi_pins,
> >   	.npins = ARRAY_SIZE(sc7280_lpi_pins),
> > @@ -149,6 +159,10 @@ static const struct of_device_id lpi_pinctrl_of_match[] = {
> >   	       .compatible = "qcom,sc7280-lpass-lpi-pinctrl",
> >   	       .data = &sc7280_lpi_data,
> >   	},
> > +	{
> > +		.compatible = "qcom,sc7280-lpass-adsp-lpi-pinctrl",
> > +		.data = &sc7280_adsp_lpi_data,
> > +	},
> >   	{ }
> >   };
> >   MODULE_DEVICE_TABLE(of, lpi_pinctrl_of_match);
> > --
> > 2.7.4