Re: [PATCH] coda: remove unused variable

From: kernel test robot
Date: Wed Jun 01 2022 - 10:21:36 EST


Hi Haowen,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.18 next-20220601]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/intel-lab-lkp/linux/commits/Haowen-Bai/coda-remove-unused-variable/20220601-160014
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 700170bf6b4d773e328fa54ebb70ba444007c702
config: i386-randconfig-a005 (https://download.01.org/0day-ci/archive/20220601/202206012213.GcFzu36Y-lkp@xxxxxxxxx/config)
compiler: gcc-11 (Debian 11.3.0-1) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/627c05172e8d819cb8dca41dfa795baae03ea6f9
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Haowen-Bai/coda-remove-unused-variable/20220601-160014
git checkout 627c05172e8d819cb8dca41dfa795baae03ea6f9
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash fs/coda/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

fs/coda/upcall.c: In function 'venus_setattr':
fs/coda/upcall.c:115:27: warning: variable 'outp' set but not used [-Wunused-but-set-variable]
115 | union outputArgs *outp;
| ^~~~
fs/coda/upcall.c: In function 'venus_close':
fs/coda/upcall.c:164:27: warning: variable 'outp' set but not used [-Wunused-but-set-variable]
164 | union outputArgs *outp;
| ^~~~
fs/coda/upcall.c: In function 'venus_rename':
fs/coda/upcall.c:238:27: warning: variable 'outp' set but not used [-Wunused-but-set-variable]
238 | union outputArgs *outp;
| ^~~~
fs/coda/upcall.c: In function 'venus_rmdir':
fs/coda/upcall.c:306:27: warning: variable 'outp' set but not used [-Wunused-but-set-variable]
306 | union outputArgs *outp;
| ^~~~
fs/coda/upcall.c: In function 'venus_remove':
fs/coda/upcall.c:329:27: warning: variable 'outp' set but not used [-Wunused-but-set-variable]
329 | union outputArgs *outp;
| ^~~~
fs/coda/upcall.c: In function 'venus_link':
fs/coda/upcall.c:383:27: warning: variable 'outp' set but not used [-Wunused-but-set-variable]
383 | union outputArgs *outp;
| ^~~~
fs/coda/upcall.c: In function 'venus_symlink':
fs/coda/upcall.c:410:27: warning: variable 'outp' set but not used [-Wunused-but-set-variable]
410 | union outputArgs *outp;
| ^~~~
fs/coda/upcall.c: In function 'venus_fsync':
fs/coda/upcall.c:443:27: warning: variable 'outp' set but not used [-Wunused-but-set-variable]
443 | union outputArgs *outp;
| ^~~~
fs/coda/upcall.c: In function 'venus_access':
fs/coda/upcall.c:459:27: warning: variable 'outp' set but not used [-Wunused-but-set-variable]
459 | union outputArgs *outp;
| ^~~~
fs/coda/upcall.c: In function 'venus_pioctl':
>> fs/coda/upcall.c:63:51: error: 'insize' undeclared (first use in this function); did you mean 'iocsize'?
63 | inp = (union inputArgs *)alloc_upcall(op, insize); \
| ^~~~~~
fs/coda/upcall.c:483:9: note: in expansion of macro 'UPARG'
483 | UPARG(CODA_IOCTL);
| ^~~~~
fs/coda/upcall.c:63:51: note: each undeclared identifier is reported only once for each function it appears in
63 | inp = (union inputArgs *)alloc_upcall(op, insize); \
| ^~~~~~
fs/coda/upcall.c:483:9: note: in expansion of macro 'UPARG'
483 | UPARG(CODA_IOCTL);
| ^~~~~
fs/coda/upcall.c: In function 'venus_access_intent':
fs/coda/upcall.c:576:27: warning: variable 'outp' set but not used [-Wunused-but-set-variable]
576 | union outputArgs *outp;
| ^~~~


vim +63 fs/coda/upcall.c

^1da177e4c3f41 Linus Torvalds 2005-04-16 60
^1da177e4c3f41 Linus Torvalds 2005-04-16 61 #define UPARG(op)\
^1da177e4c3f41 Linus Torvalds 2005-04-16 62 do {\
^1da177e4c3f41 Linus Torvalds 2005-04-16 @63 inp = (union inputArgs *)alloc_upcall(op, insize); \
^1da177e4c3f41 Linus Torvalds 2005-04-16 64 if (IS_ERR(inp)) { return PTR_ERR(inp); }\
^1da177e4c3f41 Linus Torvalds 2005-04-16 65 outp = (union outputArgs *)(inp); \
^1da177e4c3f41 Linus Torvalds 2005-04-16 66 outsize = insize; \
^1da177e4c3f41 Linus Torvalds 2005-04-16 67 } while (0)
^1da177e4c3f41 Linus Torvalds 2005-04-16 68

--
0-DAY CI Kernel Test Service
https://01.org/lkp