Re: [PATCH AUTOSEL 5.18 35/49] KVM: arm64: vgic: Do not ignore vgic_its_restore_cte failures

[Marc Zyngier]

On Wed, 01 Jun 2022 14:51:59 +0100,
Sasha Levin <sashal@xxxxxxxxxx> wrote:
> 
> From: Ricardo Koller <ricarkol@xxxxxxxxxx>
> 
> [ Upstream commit a1ccfd6f6e06eceb632cc29c4f15a32860f05a7e ]
> 
> Restoring a corrupted collection entry (like an out of range ID) is
> being ignored and treated as success. More specifically, a
> vgic_its_restore_cte failure is treated as success by
> vgic_its_restore_collection_table.  vgic_its_restore_cte uses positive
> and negative numbers to return error, and +1 to return success.  The
> caller then uses "ret > 0" to check for success.
> 
> Fix this by having vgic_its_restore_cte only return negative numbers on
> error.  Do this by changing alloc_collection return codes to only return
> negative numbers on error.
> 
> Signed-off-by: Ricardo Koller <ricarkol@xxxxxxxxxx>
> Reviewed-by: Oliver Upton <oupton@xxxxxxxxxx>
> Signed-off-by: Marc Zyngier <maz@xxxxxxxxxx>
> Link: https://lore.kernel.org/r/20220510001633.552496-4-ricarkol@xxxxxxxxxx
> Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

Same thing here. This wasn't tagged for stable. I don't think there is
much value in taking this in isolation.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.