Re: [PATCH AUTOSEL 4.9 03/11] selftests/resctrl: Change the default limited time to 120 seconds

[Reinette Chatre]

Dear Stable Team,

I received the below notice about this commit being considered for
4.9 as well as other notices for it being considered for 4.14, 4.19,
5.4, 5.10, 5.15, 5.17, and 5.18.

I do not believe this commit is appropriate for stable because:
- It forms part of a series and without the other accompanying patches
  from that series it does not do anything. Series is at:
  https://lore.kernel.org/lkml/20220323081227.1603991-1-tan.shaopeng@xxxxxxxxxxxxxx/
- The original series was not not submitted for inclusion to stable and
  none of its patches have a Fixes: tag.
- The series this patch forms part of aims to port resctrl_tests to the
  kselftest framework and I do not believe such a change matches stable
  criteria.

Reinette

On 6/1/2022 7:00 AM, Sasha Levin wrote:
> From: Shaopeng Tan <tan.shaopeng@xxxxxxxxxxxxxx>
> 
> [ Upstream commit e2e3fb6ef0d6548defbe0be6e092397aaa92f3a1 ]
> 
> When testing on a Intel(R) Xeon(R) Gold 6254 CPU @ 3.10GHz the resctrl
> selftests fail due to timeout after exceeding the default time limit of
> 45 seconds. On this system the test takes about 68 seconds.
> Since the failing test by default accesses a fixed size of memory, the
> execution time should not vary significantly between different environment.
> A new default of 120 seconds should be sufficient yet easy to customize
> with the introduction of the "settings" file for reference.
> 
> Reviewed-by: Reinette Chatre <reinette.chatre@xxxxxxxxx>
> Reviewed-by: Fenghua Yu <fenghua.yu@xxxxxxxxx>
> Signed-off-by: Shaopeng Tan <tan.shaopeng@xxxxxxxxxxxxxx>
> Signed-off-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
> ---
>  tools/testing/selftests/resctrl/settings | 3 +++
>  1 file changed, 3 insertions(+)
>  create mode 100644 tools/testing/selftests/resctrl/settings
> 
> diff --git a/tools/testing/selftests/resctrl/settings b/tools/testing/selftests/resctrl/settings
> new file mode 100644
> index 000000000000..a383f3d4565b
> --- /dev/null
> +++ b/tools/testing/selftests/resctrl/settings
> @@ -0,0 +1,3 @@
> +# If running time is longer than 120 seconds when new tests are added in
> +# the future, increase timeout here.
> +timeout=120