Re: [PATCH 2/3] thermal/debugfs: Add debugfs information
From: kernel test robot
Date: Wed Jun 01 2022 - 18:55:35 EST
Hi Daniel,
I love your patch! Yet something to improve:
[auto build test ERROR on rafael-pm/thermal]
[also build test ERROR on v5.18 next-20220601]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Daniel-Lezcano/thermal-core-Encapsulate-the-set_cur_state-function/20220601-231733
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git thermal
config: x86_64-randconfig-a011 (https://download.01.org/0day-ci/archive/20220602/202206020607.DHohHTFP-lkp@xxxxxxxxx/config)
compiler: gcc-11 (Debian 11.3.0-1) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/04c295f7e8b49af742179609949736f6f056b49c
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Daniel-Lezcano/thermal-core-Encapsulate-the-set_cur_state-function/20220601-231733
git checkout 04c295f7e8b49af742179609949736f6f056b49c
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All errors (new ones prefixed by >>):
ld: drivers/thermal/thermal_core.o: in function `thermal_init':
>> drivers/thermal/thermal_core.c:1496: undefined reference to `thermal_debugfs_init'
vim +1496 drivers/thermal/thermal_core.c
1470
1471 static int __init thermal_init(void)
1472 {
1473 int result;
1474
1475 result = thermal_netlink_init();
1476 if (result)
1477 goto error;
1478
1479 result = thermal_register_governors();
1480 if (result)
1481 goto error;
1482
1483 result = class_register(&thermal_class);
1484 if (result)
1485 goto unregister_governors;
1486
1487 result = of_parse_thermal_zones();
1488 if (result)
1489 goto unregister_class;
1490
1491 result = register_pm_notifier(&thermal_pm_nb);
1492 if (result)
1493 pr_warn("Thermal: Can not register suspend notifier, return %d\n",
1494 result);
1495
> 1496 thermal_debugfs_init();
--
0-DAY CI Kernel Test Service
https://01.org/lkp