Re: [PATCH bpf-next 5/5] bpf: trampoline: support FTRACE_OPS_FL_SHARE_IPMODIFY

From: kernel test robot
Date: Wed Jun 01 2022 - 21:31:41 EST


Hi Song,

I love your patch! Yet something to improve:

[auto build test ERROR on bpf-next/master]

url: https://github.com/intel-lab-lkp/linux/commits/Song-Liu/ftrace-host-klp-and-bpf-trampoline-together/20220602-020112
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: x86_64-randconfig-a006 (https://download.01.org/0day-ci/archive/20220602/202206020957.KETjl2xP-lkp@xxxxxxxxx/config)
compiler: gcc-11 (Debian 11.3.0-1) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/7edcf1c49617641579f2bc36b86c7d59bea20aef
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Song-Liu/ftrace-host-klp-and-bpf-trampoline-together/20220602-020112
git checkout 7edcf1c49617641579f2bc36b86c7d59bea20aef
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

kernel/bpf/trampoline.c: In function 'bpf_trampoline_lookup':
>> kernel/bpf/trampoline.c:101:17: error: 'struct ftrace_ops' has no member named 'ops_func'
101 | tr->fops->ops_func = bpf_tramp_ftrace_ops_func;
| ^~
kernel/bpf/trampoline.c: In function 'bpf_trampoline_update':
>> kernel/bpf/trampoline.c:416:25: error: 'struct ftrace_ops' has no member named 'trampoline'
416 | tr->fops->trampoline = 0;
| ^~


vim +101 kernel/bpf/trampoline.c

74
75 static struct bpf_trampoline *bpf_trampoline_lookup(u64 key)
76 {
77 struct bpf_trampoline *tr;
78 struct hlist_head *head;
79 int i;
80
81 mutex_lock(&trampoline_mutex);
82 head = &trampoline_table[hash_64(key, TRAMPOLINE_HASH_BITS)];
83 hlist_for_each_entry(tr, head, hlist) {
84 if (tr->key == key) {
85 refcount_inc(&tr->refcnt);
86 goto out;
87 }
88 }
89 tr = kzalloc(sizeof(*tr), GFP_KERNEL);
90 if (!tr)
91 goto out;
92 tr->fops = kzalloc(sizeof(struct ftrace_ops), GFP_KERNEL);
93 if (!tr->fops) {
94 kfree(tr);
95 tr = NULL;
96 goto out;
97 }
98
99 tr->key = key;
100 tr->fops->private = tr;
> 101 tr->fops->ops_func = bpf_tramp_ftrace_ops_func;
102 INIT_HLIST_NODE(&tr->hlist);
103 hlist_add_head(&tr->hlist, head);
104 refcount_set(&tr->refcnt, 1);
105 mutex_init(&tr->mutex);
106 for (i = 0; i < BPF_TRAMP_MAX; i++)
107 INIT_HLIST_HEAD(&tr->progs_hlist[i]);
108 out:
109 mutex_unlock(&trampoline_mutex);
110 return tr;
111 }
112

--
0-DAY CI Kernel Test Service
https://01.org/lkp