Re: [PATCH v3 08/16] arm64: topology: Remove redundant setting of llc_id in CPU topology

[Gavin Shan]

On 5/25/22 4:14 PM, Sudeep Holla wrote:
> Since the cacheinfo LLC information is used directly in arch_topology,
> there is no need to parse and fetch the LLC ID information only for
> ACPI systems.
>
> Just drop the redundant parsing and setting of llc_id in CPU topology
> from ACPI PPTT.
>
> Signed-off-by: Sudeep Holla <sudeep.holla@xxxxxxx>
> ---
>   arch/arm64/kernel/topology.c | 14 --------------
>   1 file changed, 14 deletions(-)

Reviewed-by: Gavin Shan <gshan@xxxxxxxxxx>

> diff --git a/arch/arm64/kernel/topology.c b/arch/arm64/kernel/topology.c
> index 9ab78ad826e2..869ffc4d4484 100644
> --- a/arch/arm64/kernel/topology.c
> +++ b/arch/arm64/kernel/topology.c
> @@ -89,8 +89,6 @@ int __init parse_acpi_topology(void)
>   		return 0;
>   
>   	for_each_possible_cpu(cpu) {
> -		int i, cache_id;
> -
>   		topology_id = find_acpi_cpu_topology(cpu, 0);
>   		if (topology_id < 0)
>   			return topology_id;
> @@ -107,18 +105,6 @@ int __init parse_acpi_topology(void)
>   		cpu_topology[cpu].cluster_id = topology_id;
>   		topology_id = find_acpi_cpu_topology_package(cpu);
>   		cpu_topology[cpu].package_id = topology_id;
> -
> -		i = acpi_find_last_cache_level(cpu);
> -
> -		if (i > 0) {
> -			/*
> -			 * this is the only part of cpu_topology that has
> -			 * a direct relationship with the cache topology
> -			 */
> -			cache_id = find_acpi_cpu_cache_topology(cpu, i);
> -			if (cache_id > 0)
> -				cpu_topology[cpu].llc_id = cache_id;
> -		}
>   	}
>   
>   	return 0;