Re: [PATCH] memory: samsung: exynos5422-dmc: Fix refcount leak in of_get_dram_timings

From: Lukasz Luba
Date: Thu Jun 02 2022 - 03:40:20 EST




On 6/2/22 05:17, Miaoqian Lin wrote:
of_parse_phandle() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
This function doesn't call of_node_put() in some error paths.
To unify the structure, Add put_node label and goto it on errors.

Fixes: 6e7674c3c6df ("memory: Add DMC driver for Exynos5422")
Signed-off-by: Miaoqian Lin <linmq006@xxxxxxxxx>

Thanks for the patch, LGTM.

Reviewed-by: Lukasz Luba <lukasz.luba@xxxxxxx>