Re: [v2 PATCH 5/7] mm: thp: kill transparent_hugepage_active()

From: Yang Shi
Date: Thu Jun 02 2022 - 19:15:37 EST


On Thu, Jun 2, 2022 at 2:00 PM Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote:
>
> On Thu, Jun 02, 2022 at 11:21:57AM -0700, Yang Shi wrote:
> > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h
> > index 79d5919beb83..f315c70d5256 100644
> > --- a/include/linux/huge_mm.h
> > +++ b/include/linux/huge_mm.h
> > @@ -209,7 +209,9 @@ static inline bool file_thp_enabled(struct vm_area_struct *vma)
> > !inode_is_open_for_write(inode) && S_ISREG(inode->i_mode);
> > }
> >
> > -bool transparent_hugepage_active(struct vm_area_struct *vma);
> > +extern bool hugepage_vma_check(struct vm_area_struct *vma,
>
> Please remove the 'extern's. They add no value to function
> declarations.

Yeah, thanks for catching this.

>