Re: [PATCH v5 1/8] perf record ibs: Warn about sampling period skew

From: Ravi Bangoria
Date: Fri Jun 03 2022 - 01:14:04 EST


>> + if (ibs_fetch_pmu && ibs_fetch_pmu->type == evsel_pmu->type) {
>> + if (attr->config & (1ULL << 59)) {
>
> It'd be nice if we used a macro or something instead of the
> magic number.
>
>> + ibs_l3miss_warn();
>> + warned_once = 1;
>> + }
>> + } else if (ibs_op_pmu && ibs_op_pmu->type == evsel_pmu->type) {
>> + if (attr->config & (1ULL << 16)) {
>
> Ditto.

Thanks for the review, Namhyung.

Arnaldo, Would you be able to squash below trivial patch into original
patch? Please let me know if you want me to respin the series instead.

---><---