Re: [PATCH v5 6/8] perf/x86/ibs: Add new IBS register bits into header

From: Ravi Bangoria
Date: Fri Jun 03 2022 - 01:25:04 EST



On 03-Jun-22 3:18 AM, Namhyung Kim wrote:
> On Tue, May 31, 2022 at 8:30 PM Ravi Bangoria <ravi.bangoria@xxxxxxx> wrote:
>>
>> IBS support has been enhanced with two new features in upcoming uarch:
>> 1. DataSrc extension and 2. L3 miss filtering. Additional set of bits
>> has been introduced in IBS registers to exploit these features. Define
>> these new bits into arch/x86/ header.
>>
>> Signed-off-by: Ravi Bangoria <ravi.bangoria@xxxxxxx>
>> Acked-by: Ian Rogers <irogers@xxxxxxxxxx>
>
> Isn't it a part of kernel changes?

Yes, that was left out because in the initial versions I did not have a
separate patch for kernel and tools. So Peter might not have consider it.
In any case, the changes into this header file are not used by kernel
atm. So I'm fine whichever way it goes in.

Thanks,
Ravi