Re: [PATCH v3 5/5] dt-bindings: altera: Add Chameleon v3 board

[Krzysztof Kozlowski]

On 03/06/2022 08:58, Paweł Anikiel wrote:
> Add Mercury+ AA1 boards category, together with the Chameleon v3 board.
> 
> Signed-off-by: Paweł Anikiel <pan@xxxxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/arm/altera.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/altera.yaml b/Documentation/devicetree/bindings/arm/altera.yaml
> index 5e2017c0a051..4a08c082dbdb 100644
> --- a/Documentation/devicetree/bindings/arm/altera.yaml
> +++ b/Documentation/devicetree/bindings/arm/altera.yaml
> @@ -29,6 +29,14 @@ properties:
>            - const: altr,socfpga-arria10
>            - const: altr,socfpga
>  
> +      - description: Mercury+ AA1 boards

This looks good but you also need to remove enclustra,mercury-aa1 from
previous entry because after your changes to DTSI, it should not be a
standalone (final) compatible.

> +        items:
> +          - enum:
> +              - google,chameleon-v3
> +          - const: enclustra,mercury-aa1
> +          - const: altr,socfpga-arria10
> +          - const: altr,socfpga
> +
>        - description: Cyclone 5 boards
>          items:
>            - enum:


Best regards,
Krzysztof