Re: [PATCH 03/10] dt-bindings: iio: adc: axp209: Add AXP192 compatible
From: Jonathan Cameron
Date: Fri Jun 03 2022 - 12:25:13 EST
On Fri, 3 Jun 2022 14:57:07 +0100
Aidan MacDonald <aidanmacdonald.0x0@xxxxxxxxx> wrote:
> The AXP192 is identical to the AXP20x, except for two additional
> GPIO ADC channels.
>
> Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@xxxxxxxxx>
There is an argument that could be made here to say this should
have a fallback compatible to a suitable existing part as the driver
would work, we'd just be missing a couple of channels.
I don't feel strongly either way, but thought I'd raise the possibility.
I guess it's irrelevant if an updated kernel is needed anyway to have
it functional because of support needed for some other part of the chip
though.
Jonathan
> ---
> .../bindings/iio/adc/x-powers,axp209-adc.yaml | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/x-powers,axp209-adc.yaml b/Documentation/devicetree/bindings/iio/adc/x-powers,axp209-adc.yaml
> index d6d3d8590171..1a68e650ac7d 100644
> --- a/Documentation/devicetree/bindings/iio/adc/x-powers,axp209-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/x-powers,axp209-adc.yaml
> @@ -14,6 +14,23 @@ description: |
> Device is a child of an axp209 multifunction device
> ADC channels and their indexes per variant:
>
> + AXP192
> + ------
> + 0 | acin_v
> + 1 | acin_i
> + 2 | vbus_v
> + 3 | vbus_i
> + 4 | pmic_temp
> + 5 | gpio0_v
> + 6 | gpio1_v
> + 7 | gpio2_v
> + 8 | gpio3_v
> + 9 | ipsout_v
> + 10 | batt_v
> + 11 | batt_chrg_i
> + 12 | batt_dischrg_i
> + 13 | ts_v
> +
> AXP209
> ------
> 0 | acin_v
> @@ -50,6 +67,7 @@ description: |
> properties:
> compatible:
> oneOf:
> + - const: x-powers,axp192-adc
> - const: x-powers,axp209-adc
> - const: x-powers,axp221-adc
> - const: x-powers,axp813-adc