Re: [PATCH v6 2/3] blk-cgroup: Return -ENOMEM directly in blkcg_css_alloc() error path

From: Ming Lei
Date: Fri Jun 03 2022 - 22:16:38 EST

Next message: chuang: "Re: [PATCH] kprobes: Rollback kprobe flags on failed arm_kprobe"
Previous message: Leo Yan: "Re: [PATCH v2 0/2] perf: arm64: Kernel support for Dwarf unwinding through SVE functions"
In reply to: Tejun Heo: "Re: [PATCH v6 2/3] blk-cgroup: Return -ENOMEM directly in blkcg_css_alloc() error path"
Next in thread: Waiman Long: "[PATCH v6 1/3] blk-cgroup: Correctly free percpu iostat_cpu in blkg on error exit"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Thu, Jun 02, 2022 at 03:20:19PM -0400, Waiman Long wrote:
> For blkcg_css_alloc(), the only error that will be returned is -ENOMEM.
> Simplify error handling code by returning this error directly instead
> of setting an intermediate "ret" variable.
>
> Signed-off-by: Waiman Long <longman@xxxxxxxxxx>

Looks fine:

Reviewed-by: Ming Lei <ming.lei@xxxxxxxxxx>

Thanks,
Ming

Next message: chuang: "Re: [PATCH] kprobes: Rollback kprobe flags on failed arm_kprobe"
Previous message: Leo Yan: "Re: [PATCH v2 0/2] perf: arm64: Kernel support for Dwarf unwinding through SVE functions"
In reply to: Tejun Heo: "Re: [PATCH v6 2/3] blk-cgroup: Return -ENOMEM directly in blkcg_css_alloc() error path"
Next in thread: Waiman Long: "[PATCH v6 1/3] blk-cgroup: Correctly free percpu iostat_cpu in blkg on error exit"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]