Re: [PATCH v4 2/7] can: Kconfig: turn menu "CAN Device Drivers" into a menuconfig using CAN_DEV

From: Marc Kleine-Budde
Date: Sat Jun 04 2022 - 08:43:14 EST


On 04.06.2022 21:30:57, Vincent MAILHOL wrote:
> > > diff --git a/drivers/net/can/dev/Makefile b/drivers/net/can/dev/Makefile
> > > index 5b4c813c6222..919f87e36eed 100644
> > > --- a/drivers/net/can/dev/Makefile
> > > +++ b/drivers/net/can/dev/Makefile
> > > @@ -1,9 +1,11 @@
> > > # SPDX-License-Identifier: GPL-2.0
> > >
> > > -obj-$(CONFIG_CAN_NETLINK) += can-dev.o
> > > +obj-$(CONFIG_CAN_DEV) += can-dev.o
> > ^^^^^^^^^^^^^^^^^^^^^
> >
> > Nitpick: I think you can directly use "y" here.
>
> I see. So the idea would be that if we deselect CONFIG_CAN_DEV, then
> despite of can-dev.o being always "yes", it would be empty and thus
> ignored.

ACK

Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

Attachment: signature.asc
Description: PGP signature