Re: [PATCH 2/4] mm/shmem: return -EINVAL for addr not PAGE_SIZE aligned

From: Chen Wandun
Date: Sat Jun 04 2022 - 22:05:46 EST




On 2022/6/1 22:14, David Hildenbrand wrote:
On 01.06.22 15:37, David Hildenbrand wrote:
On 01.06.22 14:44, Chen Wandun wrote:
If addr is not PAGE_SIZE aligned, return -EINVAL directly.
Why is this one to be treated in a special way compared to all of the
other related checks?
Ah, I see you modify other places in other patches. Maybe just combine
all these return value changes into a single patch? That makes it look
less "special".
OK, patch 2 and patch 3 are used to return error value directly, I will combine these patch
to a single patch in next version.

Thanks.