Re: [PATCH v2 1/3] mm/shmem: check return value of shmem_init_inodecache
From: Matthew Wilcox
Date: Sun Jun 05 2022 - 08:21:21 EST
On Sun, Jun 05, 2022 at 11:55:55AM +0800, Chen Wandun wrote:
> It will result in null pointer access if shmem_init_inodecache fail,
> so check return value of shmem_init_inodecache
You ignored my suggestion from v1. Here, let me write it out for you.
+static int shmem_init_inodecache(void)
{
shmem_inode_cachep = kmem_cache_create("shmem_inode_cache",
sizeof(struct shmem_inode_info),
0, SLAB_PANIC|SLAB_ACCOUNT, shmem_init_inode);
+ if (!shmem_inode_cachep)
+ return -ENOMEM;
+ return 0;
}
...
+ error = shmem_init_inodecache();
+ if (error)
+ goto out2;