Re: [PATCH] dt-bindings: interrupt-controller: Convert rda,8810pl-intc to YAML

From: Krzysztof Kozlowski
Date: Sun Jun 05 2022 - 10:51:01 EST


On 03/06/2022 14:12, Stanislav Jakubek wrote:
> On Sun, May 29, 2022 at 04:05:12PM +0200, Krzysztof Kozlowski wrote:
>> On 27/05/2022 14:56, Stanislav Jakubek wrote:
>>> Convert RDA Micro interrupt controller bindings to DT schema format.
>>>
>>> Signed-off-by: Stanislav Jakubek <stano.jakubek@xxxxxxxxx>
>>> ---
>>>
>>> Didn't know what to do about the interrupt sources listed in the original txt file,
>>> so I've split them off into a separate file. Hope that's okay.
>>
>> Interrupt sources are not kept in header files.
>
> Ok, should I move them somewhere else or is it fine to drop them?

Either drop them or, if they are meaningful, keep in description. I
doubt that they are meaningful, but who knows...

>
>> Additionally are you
>> sure this is a property of the interrupt controller, not a property of
>> SoC itself? I would assume that one interrupt controller implementation
>> (e.g. GIC) can be used in different SoCs and the sources are every time
>> different because they depend on the actual wiring...
>>
>
> I honestly have no idea, I just wanted to make some YAML conversions.
> Maybe Mani could answer this?


Best regards,
Krzysztof