Re: [PATCH v2] media: imx-jpeg: Correct some definition according specification

[mirela.rabulea@xxxxxxxxxxx]

On 30.05.2022 10:47, Ming Qian wrote:
> the register CAST_NOMFRSIZE_LO should be equal to CAST_STATUS16
> the register CAST_NOMFRSIZE_HI should be equal to CAST_STATUS17
> the register CAST_OFBSIZE_LO should be equal to CAST_STATUS18
> the register CAST_OFBSIZE_HI should be equal to CAST_STATUS19
>
> Fixes: 2db16c6ed72ce ("media: imx-jpeg: Add V4L2 driver for i.MX8 JPEG Encoder/Decoder")
> Signed-off-by: Ming Qian <ming.qian@xxxxxxx>

Reviewed-by: Mirela Rabulea <mirela.rabulea@xxxxxxx>

> ---
> v2
> - add Fixes tag
>   drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.h | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.h b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.h
> index e7e8954754b1..07655502f4bd 100644
> --- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.h
> +++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.h
> @@ -53,10 +53,10 @@
>   #define CAST_REC_REGS_SEL		CAST_STATUS4
>   #define CAST_LUMTH			CAST_STATUS5
>   #define CAST_CHRTH			CAST_STATUS6
> -#define CAST_NOMFRSIZE_LO		CAST_STATUS7
> -#define CAST_NOMFRSIZE_HI		CAST_STATUS8
> -#define CAST_OFBSIZE_LO			CAST_STATUS9
> -#define CAST_OFBSIZE_HI			CAST_STATUS10
> +#define CAST_NOMFRSIZE_LO		CAST_STATUS16
> +#define CAST_NOMFRSIZE_HI		CAST_STATUS17
> +#define CAST_OFBSIZE_LO			CAST_STATUS18
> +#define CAST_OFBSIZE_HI			CAST_STATUS19
>   
>   #define MXC_MAX_SLOTS	1 /* TODO use all 4 slots*/
>   /* JPEG-Decoder Wrapper Slot Registers 0..3 */