Re: [PATCH 1/3] dt-bindings: crypto: fsl: add entropy delay property

[Rob Herring]

On Mon, May 30, 2022 at 11:39:22PM +0530, Vabhav Sharma wrote:
> Add entropy delay property which defines the length (in system clocks) of
> each Entropy sample taken for TRNG configuration.
> 
> Signed-off-by: Vabhav Sharma <vabhav.sharma@xxxxxxx>
> Reviewed-by: Horia Geanta <horia.geanta@xxxxxxx>
> Reviewed-by: Varun Sethi <v.sethi@xxxxxxx>
> ---
>  Documentation/devicetree/bindings/crypto/fsl-sec4.txt | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/crypto/fsl-sec4.txt b/Documentation/devicetree/bindings/crypto/fsl-sec4.txt
> index 8f359f473ada..1477294eda38 100644
> --- a/Documentation/devicetree/bindings/crypto/fsl-sec4.txt
> +++ b/Documentation/devicetree/bindings/crypto/fsl-sec4.txt
> @@ -62,6 +62,12 @@ PROPERTIES
>        Definition: A standard property. Define the 'ERA' of the SEC
>            device.
>  
> +   - entropy-delay
> +      Usage: optional
> +      Value type: <u32>
> +      Definition: A property which specifies the length (in system clocks)
> +          of each Entropy sample taken.
> +

Seems like this could be common, but should be a time value (with unit 
suffix) rather than clocks. If not common, then needs a vendor prefix. 
Is this time to read a value or time between values produced? Not really 
clear from the description.

Rob