[PATCH] USB: serial: Remove redundant NULL check before release_firmware() call

From: cgel . zte
Date: Sun Jun 05 2022 - 21:43:23 EST


From: Minghao Chi <chi.minghao@xxxxxxxxxx>

release_firmware() checks for NULL pointers internally so checking
before calling it is redundant.

Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
Signed-off-by: Minghao Chi <chi.minghao@xxxxxxxxxx>
---
drivers/usb/serial/mxuport.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/usb/serial/mxuport.c b/drivers/usb/serial/mxuport.c
index eb45a9b0005c..eb9090ab900f 100644
--- a/drivers/usb/serial/mxuport.c
+++ b/drivers/usb/serial/mxuport.c
@@ -1109,8 +1109,7 @@ static int mxuport_probe(struct usb_serial *serial,
*/
usb_set_serial_data(serial, (void *)id->driver_info);
out:
- if (fw_p)
- release_firmware(fw_p);
+ release_firmware(fw_p);
return err;
}

--
2.25.1