Re: [RFC PATCH 2/3] clk: bd718x7: Enable the possibility to mark the clock as critical
From: Matti Vaittinen
Date: Mon Jun 06 2022 - 01:29:47 EST
Hi Michael,
On 6/5/22 19:57, Michael Trimarchi wrote:
If the clock is used to generate the osc_32k, we need to mark
as critical. clock-critical has no binding description at the moment
but it's defined in linux kernel
bd71847: pmic@4b {
...
rohm,reset-snvs-powered;
#clock-cells = <0>;
clock-critical = <1>;
clocks = <&osc_32k 0>;
clock-output-names = "clk-32k-out";
...
}
Signed-off-by: Michael Trimarchi <michael@xxxxxxxxxxxxxxxxxxxx>
---
drivers/clk/clk-bd718x7.c | 4 ++++
//snip
@@ -100,6 +101,9 @@ static int bd71837_clk_probe(struct platform_device *pdev)
parent_clk = of_clk_get_parent_name(parent->of_node, 0);
+ of_clk_detect_critical(dev->of_node, 0, &flags);
Purely judging the kerneldoc for of_clk_detect_critical - you may have
hard time getting this accepted.
I think you're working on a very valid problem though. Maybe you could
see if you could align your effort with Marek?
https://lore.kernel.org/all/20220517235919.200375-1-marex@xxxxxxx/T/#m52d6d0831bf43d5f293e35cb27f3021f278d0564
Best Regards
-- Matti
--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland
~~ When things go utterly wrong vim users can always type :help! ~~
Discuss - Estimate - Plan - Report and finally accomplish this:
void do_work(int time) __attribute__ ((const));