Re: [PATCH] stmmac: intel: Fix an error handling path in intel_eth_pci_probe()

From: Wong Vee Khee
Date: Mon Jun 06 2022 - 02:27:12 EST


On Sun, Jun 05, 2022 at 10:50:48PM +0200, Christophe JAILLET wrote:
> When the managed API is used, there is no need to explicitly call
> pci_free_irq_vectors().
>
> This looks to be a left-over from the commit in the Fixes tag. Only the
> .remove() function had been updated.
>
> So remove this unused function call and update goto label accordingly.
>
> Fixes: 8accc467758e ("stmmac: intel: use managed PCI function on probe and resume")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> ---
> drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>

LGTM

Reviewed-by: Wong Vee Khee <vee.khee.wong@xxxxxxxxxxxxxxx>