Re: [RESEND PATCH] misc: atmel-ssc: Fix IRQ check in ssc_probe

[Claudiu.Beznea]

On 01.06.2022 15:30, Miaoqian Lin wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> platform_get_irq() returns negative error number instead 0 on failure.
> And the doc of platform_get_irq() provides a usage example:
> 
>     int irq = platform_get_irq(pdev, 0);
>     if (irq < 0)
>         return irq;
> 
> Fix the check of return value to catch errors correctly.
> 
> Fixes: eb1f2930609b ("Driver for the Atmel on-chip SSC on AT32AP and AT91")
> Signed-off-by: Miaoqian Lin <linmq006@xxxxxxxxx>

Reviewed-by: Claudiu Beznea <claudiu.beznea@xxxxxxxxxxxxx>


> ---
>  drivers/misc/atmel-ssc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c
> index d6cd5537126c..69f9b0336410 100644
> --- a/drivers/misc/atmel-ssc.c
> +++ b/drivers/misc/atmel-ssc.c
> @@ -232,9 +232,9 @@ static int ssc_probe(struct platform_device *pdev)
>         clk_disable_unprepare(ssc->clk);
> 
>         ssc->irq = platform_get_irq(pdev, 0);
> -       if (!ssc->irq) {
> +       if (ssc->irq < 0) {
>                 dev_dbg(&pdev->dev, "could not get irq\n");
> -               return -ENXIO;
> +               return ssc->irq;
>         }
> 
>         mutex_lock(&user_lock);
> --
> 2.25.1
>