Re: [PATCH] lib/flex_proportions.c: Remove local_irq_ops in fprop_new_period()

From: Jan Kara
Date: Mon Jun 06 2022 - 03:50:51 EST


On Mon 06-06-22 09:44:44, Jan Kara wrote:
> On Sat 04-06-22 21:15:02, wuchi wrote:
> > The commit <e78d4833c03e28> (lib: Fix possible deadlock in flexible
> > proportion code) adds the local_irq_ops because percpu_counter_{sum
> > |add} ops'lock can cause deadlock by interrupts. Now percpu_counter
> > _{sum|add} ops use raw_spin_(un)lock_irq*, so revert the commit and
> > resolve the conflict.
> >
> > Signed-off-by: wuchi <wuchi.zero@xxxxxxxxx>
>
> Yes, good point. Thanks for cleaning this up. Feel free to add:
>
> Reviewed-by: Jan Kara <jack@xxxxxxx>
>
> I guess Andrew will pickup this patch, or should I do it Andrew?

Oh, I can see Andrew already did pickup the patch. So everything is fine
:).
Honza
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR