Re: [PATCH 2/2] arm64: dts: rockchip: rock-pi-s add more peripherals

[Michael Riesch]

Hi,

On 6/6/22 10:26, Sjoerd Simons wrote:
> This enables the following peripherals:
> * Onboard ethernet support
> * Bluetooth
> * USB 2 port
> * OTG port via type-c connector
> * Hardware watchog
> 
> Also add aliases for the mmc devices and the ethernet interface
> 
> Signed-off-by: Sjoerd Simons <sjoerd@xxxxxxxxxxxxx>
> 
> ---
> 
>  .../boot/dts/rockchip/rk3308-rock-pi-s.dts    | 52 +++++++++++++++++++
>  1 file changed, 52 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts b/arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts
> index 9095efe25ccd..46ba48b843c5 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts
> @@ -11,6 +11,12 @@ / {
>  	model = "Radxa ROCK Pi S";
>  	compatible = "radxa,rockpis", "rockchip,rk3308";
>  
> +	aliases {
> +		ethernet0 = &gmac;
> +		mmc0 = &emmc;
> +		mmc1 = &sdmmc;

Sure? emmc is at address ff49000 which is larger than sdmmc's address
ff480000. I believe the aliases should be sorted w.r.t. addresses.

Best regards,
Michael

> +	};
> +
>  	chosen {
>  		stdout-path = "serial0:1500000n8";
>  	};
> @@ -132,6 +138,15 @@ &emmc {
>  	status = "okay";
>  };
>  
> +&gmac {
> +	clock_in_out = "output";
> +	phy-supply = <&vcc_io>;
> +	snps,reset-gpio = <&gpio0 RK_PA7 GPIO_ACTIVE_LOW>;
> +	snps,reset-active-low;
> +	snps,reset-delays-us = <0 50000 50000>;
> +	status = "okay";
> +};
> +
>  &i2c1 {
>  	status = "okay";
>  };
> @@ -195,10 +210,47 @@ &sdmmc {
>  	status = "okay";
>  };
>  
> +&u2phy {
> +	status = "okay";
> +
> +	u2phy_host: host-port {
> +		phy-supply = <&vcc5v0_otg>;
> +		status = "okay";
> +	};
> +
> +	u2phy_otg: otg-port {
> +		phy-supply = <&vcc5v0_otg>;
> +		status = "okay";
> +	};
> +};
> +
>  &uart0 {
>  	status = "okay";
>  };
>  
>  &uart4 {
>  	status = "okay";
> +
> +	bluetooth {
> +		compatible = "realtek,rtl8723bs-bt";
> +		device-wake-gpios = <&gpio4 RK_PB3 GPIO_ACTIVE_HIGH>;
> +		host-wake-gpios = <&gpio4 RK_PB4 GPIO_ACTIVE_HIGH>;
> +	};
> +};
> +
> +&usb_host_ehci {
> +	status = "okay";
> +};
> +
> +&usb_host_ohci {
> +	status = "okay";
> +};
> +
> +&usb20_otg {
> +	dr_mode = "peripheral";
> +	status = "okay";
> +};
> +
> +&wdt {
> +	status = "okay";
>  };