Re: [PATCH 1/1] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332()

From: Maxime Ripard
Date: Mon Jun 06 2022 - 09:42:57 EST


Hi,

On Mon, Jun 06, 2022 at 11:55:16AM +0200, José Expósito wrote:
> Test the conversion from XRGB8888 to RGB332.
>
> What is tested?
>
> - Different values for the X in XRGB8888 to make sure it is ignored
> - Different clip values: Single pixel and full and partial buffer
> - Well known colors: White, black, red, green, blue, magenta, yellow
> and cyan
> - Other colors: Randomly picked
> - Destination pitch
>
> How to run the tests?
>
> $ ./tools/testing/kunit/kunit.py run --kunitconfig=drivers/gpu/drm \
> --kconfig_add CONFIG_VIRTIO_UML=y \
> --kconfig_add CONFIG_UML_PCI_OVER_VIRTIO=y

It's not clear to me why you would need VIRTIO here? The Kunit config
file should be enough to run the tests properly

Maxime

Attachment: signature.asc
Description: PGP signature