Re: [PATCH 1/1] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332()

[Maxime Ripard]

On Mon, Jun 06, 2022 at 03:57:45PM +0200, Javier Martinez Canillas wrote:
> Hello Maxime,
> 
> On 6/6/22 15:52, Maxime Ripard wrote:
> > hi,
> > 
> > On Mon, Jun 06, 2022 at 03:49:57PM +0200, Javier Martinez Canillas wrote:
> >> Hello Maxime,
> >>
> >> On 6/6/22 15:42, Maxime Ripard wrote:
> >>> Hi,
> >>>
> >>> On Mon, Jun 06, 2022 at 11:55:16AM +0200, José Expósito wrote:
> >>>> Test the conversion from XRGB8888 to RGB332.
> >>>>
> >>>> What is tested?
> >>>>
> >>>>  - Different values for the X in XRGB8888 to make sure it is ignored
> >>>>  - Different clip values: Single pixel and full and partial buffer
> >>>>  - Well known colors: White, black, red, green, blue, magenta, yellow
> >>>>    and cyan
> >>>>  - Other colors: Randomly picked
> >>>>  - Destination pitch
> >>>>
> >>>> How to run the tests?
> >>>>
> >>>>  $ ./tools/testing/kunit/kunit.py run --kunitconfig=drivers/gpu/drm \
> >>>>          --kconfig_add CONFIG_VIRTIO_UML=y \
> >>>>          --kconfig_add CONFIG_UML_PCI_OVER_VIRTIO=y
> >>>
> >>> It's not clear to me why you would need VIRTIO here? The Kunit config
> >>> file should be enough to run the tests properly
> >>>
> >>
> >> It's needed or otherwise KUnit will complain with:
> >>
> >> ./tools/testing/kunit/kunit.py run --kunitconfig=drivers/gpu/drm/.kunitconfig
> >> [15:47:31] Configuring KUnit Kernel ...
> >> Regenerating .config ...
> >> Populating config with:
> >> $ make ARCH=um O=.kunit olddefconfig
> >> ERROR:root:Not all Kconfig options selected in kunitconfig were in the generated .config.
> >> This is probably due to unsatisfied dependencies.
> >> Missing: CONFIG_DRM=y, CONFIG_DRM_KUNIT_TEST=y
> >> Note: many Kconfig options aren't available on UML. You can try running on a different architecture with something like "--arch=x86_64".
> >>
> >> The following works correctly but it won't use User Mode Linux:
> >>
> >> ./tools/testing/kunit/kunit.py run --kunitconfig=drivers/gpu/drm/.kunitconfig --arch=x86_64
> > 
> > But then, can't we add them to .kunitconfig?
> >
> 
> That's what I asked in the previous RFC too. Daniel mentioned that it shouldn't
> go there because is platform specific (AFAIU, one might want to test it on x86,
> aarch64, etc) but then I asked why we couldn't have a arch/um/.kunitconfig.
> 
> The answer was that's not that simple and some agreement on how to do it is needed:
> 
> https://lists.freedesktop.org/archives/dri-devel/2022-June/357617.html

Thanks for pointing this out. So yeah, it's indeed not very optimal

We should probably just document it somewhere in KMS then? It doesn't
have to be in this patch series, but I have the feeling that we will end
up with that discussion a lot from people frustrated to have spent too
much time figuring it out :)

Maxime

Attachment: signature.asc
Description: PGP signature