Re: [PATCH v19 17/20] s390/vfio-ap: handle config changed and scan complete notification

From: Jason J. Herne
Date: Mon Jun 06 2022 - 13:51:13 EST


On 4/4/22 18:10, Tony Krowiak wrote:
This patch implements two new AP driver callbacks:

void (*on_config_changed)(struct ap_config_info *new_config_info,
struct ap_config_info *old_config_info);

void (*on_scan_complete)(struct ap_config_info *new_config_info,
struct ap_config_info *old_config_info);

The on_config_changed callback is invoked at the start of the AP bus scan
function when it determines that the host AP configuration information
has changed since the previous scan.

The vfio_ap device driver registers a callback function for this callback
that performs the following operations:

1. Unplugs the adapters, domains and control domains removed from the
host's AP configuration from the guests to which they are
assigned in a single operation.

2. Stores bitmaps identifying the adapters, domains and control domains
added to the host's AP configuration with the structure representing
the mediated device. When the vfio_ap device driver's probe callback is
subsequently invoked, the probe function will recognize that the
queue is being probed due to a change in the host's AP configuration
and the plugging of the queue into the guest will be bypassed.

The on_scan_complete callback is invoked after the ap bus scan is
completed if the host AP configuration data has changed. The vfio_ap
device driver registers a callback function for this callback that hot
plugs each queue and control domain added to the AP configuration for each
guest using them in a single hot plug operation.

Signed-off-by: Tony Krowiak <akrowiak@xxxxxxxxxxxxx>
---
drivers/s390/crypto/vfio_ap_drv.c | 2 +
drivers/s390/crypto/vfio_ap_ops.c | 270 +++++++++++++++++++++++++-
drivers/s390/crypto/vfio_ap_private.h | 12 ++
3 files changed, 279 insertions(+), 5 deletions(-)

Reviewed-by: Jason J. Herne <jjherne@xxxxxxxxxxxxx>

--
-- Jason J. Herne (jjherne@xxxxxxxxxxxxx)