Re: [PATCH] PCI: microchip: Fix refcount leak in mc_pcie_init_irq_domains

From: Rob Herring
Date: Mon Jun 06 2022 - 17:33:02 EST


On Sun, Jun 5, 2022 at 12:51 AM Miaoqian Lin <linmq006@xxxxxxxxx> wrote:
>
> of_get_next_child() returns a node pointer with refcount incremented,
> we should use of_node_put() on it when not need anymore.
> This function only call of_node_put() in normal path,
> missing it in some error paths.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: 6f15a9c9f941 ("PCI: microchip: Add Microchip PolarFire PCIe controller driver")
> Signed-off-by: Miaoqian Lin <linmq006@xxxxxxxxx>
> ---
> drivers/pci/controller/pcie-microchip-host.c | 2 ++
> 1 file changed, 2 insertions(+)

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>