Re: [PATCH 12/13] platform/chrome: cros_ec_proto: arrange get_host_event_wake_mask()

From: Tzung-Bi Shih
Date: Mon Jun 06 2022 - 20:55:53 EST


On Mon, Jun 06, 2022 at 09:18:57AM -0700, Guenter Roeck wrote:
> On Mon, Jun 6, 2022 at 7:12 AM Tzung-Bi Shih <tzungbi@xxxxxxxxxx> wrote:
> >
> > - cros_ec_get_host_event_wake_mask() is a private (static) function.
> > Rename it to get_host_event_wake_mask().
> >
> Same as before - I still prefer to have prefixes. Also, this is a bit
> of point-of-view thing, so I'd rather leave function names alone
> unless there is a good reason to change them. Otherwise we might end
> up with sequences of function-name-rename patches for no good reason
> besides someone mot liking the existing names.

Ack.