Re: [PATCH 2/2] tty/vt: Makefile, add --unicode for loadkeys invocation

[Jiri Slaby]

On 06. 06. 22, 16:35, Andy Shevchenko wrote:
> On Thu, Jun 2, 2022 at 12:30 PM Jiri Slaby <jslaby@xxxxxxx> wrote:
> > For a long time, we generate unicode tables using loadkeys. So fix
> > Makefile to use that flag too.
>
> generated

We still do, but I didn't even know there is even a rule for that ;).

> Does it make sense to add the Fixes tag?

I don't think so -- I don't think anyone ran the rule in the past decade 
:P. I.e. it'd be pre-git anyway.

> Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
>
> > Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
> > ---
> >   drivers/tty/vt/Makefile | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/tty/vt/Makefile b/drivers/tty/vt/Makefile
> > index fe30ce512819..b3dfe9d5717e 100644
> > --- a/drivers/tty/vt/Makefile
> > +++ b/drivers/tty/vt/Makefile
> > @@ -30,6 +30,6 @@ $(obj)/defkeymap.o:  $(obj)/defkeymap.c
> >   ifdef GENERATE_KEYMAP
> >
> >   $(obj)/defkeymap.c: $(obj)/%.c: $(src)/%.map
> > -       loadkeys --mktable $< > $@
> > +       loadkeys --mktable --unicode $< > $@
> >
> >   endif
> > --
> > 2.36.1

thanks,
--
js
suse labs