Re: [PATCH v5 4/7] can: Kconfig: add CONFIG_CAN_RX_OFFLOAD

[Geert Uytterhoeven]

Hi Vincent,

On Sun, Jun 5, 2022 at 12:25 AM Vincent Mailhol
<mailhol.vincent@xxxxxxxxxx> wrote:
> Only a few drivers rely on the CAN rx offload framework (as of the
> writing of this patch, only four: flexcan, m_can, mcp251xfd and
> ti_hecc). Give the option to the user to deselect this features during
> compilation.

Thanks for your patch!

> The drivers relying on CAN rx offload are in different sub
> folders. All of these drivers get tagged with "select CAN_RX_OFFLOAD"
> so that the option is automatically enabled whenever one of those
> driver is chosen.

Great! But...

>
> Signed-off-by: Vincent Mailhol <mailhol.vincent@xxxxxxxxxx>

> --- a/drivers/net/can/Kconfig
> +++ b/drivers/net/can/Kconfig
> @@ -102,6 +102,20 @@ config CAN_CALC_BITTIMING
>
>           If unsure, say Y.
>
> +config CAN_RX_OFFLOAD
> +       bool "CAN RX offload"
> +       default y

... then why does this default to "y"?

> +       help
> +         Framework to offload the controller's RX FIFO during one
> +         interrupt. The CAN frames of the FIFO are read and put into a skb
> +         queue during that interrupt and transmitted afterwards in a NAPI
> +         context.
> +
> +         The additional features selected by this option will be added to the
> +         can-dev module.
> +
> +         If unsure, say Y.

... and do you suggest to enable this?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds