Re: [PATCH] sched/deadline: Use proc_douintvec_minmax() limit minimum value

[Daniel Bristot de Oliveira]

On 6/7/22 10:35, Yajun Deng wrote:
> June 7, 2022 3:55 PM, "Daniel Bristot de Oliveira" <bristot@xxxxxxxxxx> wrote:
> 
>> Hi Yajun
>>
>> On 5/13/22 04:41, Yajun Deng wrote:
>>
>>> proc_dointvec() is not applicable for unsigned integer, use
>>> proc_douintvec_minmax() limit minimum value.
>> I understand your patch, but your log message is somehow incomplete.
>>
>> Could you expand on that, showing the problem using an example, and then how you
>> see it fixed?
>>
> This patch isn't a fix. It's just an optimization for match data and proc_handler in struct ctl_table.
> 
>> Also, could you please add the Fixes: tag so this patch can land on stable trees?
>>
> This statement 'if (period < min || period > max)' in __checkparam_dl() will work fine even if there hasn't this patch.
> So this patch may not need land on stable trees.
> 

Good, so you already know how to improve your log message.

-- Daniel