Re: [PATCH] ASoC: max98390: use linux/gpio/consumer.h to fix build

From: Mark Brown
Date: Tue Jun 07 2022 - 06:46:16 EST


On Sun, 5 Jun 2022 09:31:23 -0700, Randy Dunlap wrote:
> Change the header file to fix build errors in max98390.c:
>
> ../sound/soc/codecs/max98390.c: In function 'max98390_i2c_probe':
> ../sound/soc/codecs/max98390.c:1076:22: error: implicit declaration of function 'devm_gpiod_get_optional'; did you mean 'devm_regulator_get_optional'? [-Werror=implicit-function-declaration]
> 1076 | reset_gpio = devm_gpiod_get_optional(&i2c->dev,
> ../sound/soc/codecs/max98390.c:1077:55: error: 'GPIOD_OUT_HIGH' undeclared (first use in this function); did you mean 'GPIOF_INIT_HIGH'?
> 1077 | "reset", GPIOD_OUT_HIGH);
> ../sound/soc/codecs/max98390.c:1077:55: note: each undeclared identifier is reported only once for each function it appears in
> ../sound/soc/codecs/max98390.c:1083:17: error: implicit declaration of function 'gpiod_set_value_cansleep'; did you mean 'gpio_set_value_cansleep'? [-Werror=implicit-function-declaration]
> 1083 | gpiod_set_value_cansleep(reset_gpio, 0);
>
> [...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: max98390: use linux/gpio/consumer.h to fix build
commit: aa7407f807b250eca7697e5fe9a699bc6c2fab71

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark