Re: [PATCH v3 4/6] serial: 8250: Adjust misleading LSR related comment

[Ilpo Järvinen]

On Tue, 7 Jun 2022, Andy Shevchenko wrote:

> On Tue, Jun 7, 2022 at 11:16 AM Ilpo Järvinen
> <ilpo.jarvinen@xxxxxxxxxxxxxxx> wrote:
> 
> > only flags which were not handled). Adjust the comment to match
> > behavior and warn about which flags can be depended on.
> >
> > While I'd have moved LSR read before LSR read and used serial_lsr_in()
> > also here but I came across this old discussion about the topic:
> 
> >   https://www.spinics.net/lists/linux-serial/msg20555.html
> 
> Can it be transformed to lore.kernel.org link?

Unfortunately no, AFAICT. I tried searching but I couldn't find one 
from there (In fact, I tried even before submitting them because you 
previously told me I should use lore links instead).

More importantly though, it seems that the link was not the one I was 
supposed to use (I probably copy pasted the url from a wrong window while 
investigating all turns of it). This is the correct link:

  https://www.spinics.net/lists/linux-serial/msg16220.html

> and maybe even moved as BugLink tag?

What's BugLink? Our documentation isn't particularly helpful:

$ git grep BugLink
scripts/checkpatch.pl:              $line !~ /^\s*(?:Link|Patchwork|http|https|BugLink|base-commit):/i &&
$

...It seems mostly about bug trackers such as bugzilla, etc. based on git 
log so that tag seems not relevant.

I put the correct URL now into Link tag.

I'll resend tomorrow to give the dust some time to settle.

-- 
 i.