Re: [PATCH] dt-bindings: i2c: Convert arm,i2c-versatile to DT schema

[Krzysztof Kozlowski]

On 06/06/2022 20:43, Rob Herring wrote:
> Convert the arm,i2c-versatile binding to DT schema format.
> 
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> ---
>  .../bindings/i2c/arm,i2c-versatile.yaml       | 29 +++++++++++++++++++
>  .../devicetree/bindings/i2c/i2c-versatile.txt | 10 -------
>  MAINTAINERS                                   |  2 +-
>  3 files changed, 30 insertions(+), 11 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/i2c/arm,i2c-versatile.yaml
>  delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-versatile.txt
> 
> diff --git a/Documentation/devicetree/bindings/i2c/arm,i2c-versatile.yaml b/Documentation/devicetree/bindings/i2c/arm,i2c-versatile.yaml
> new file mode 100644
> index 000000000000..e58465d1b0c8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/arm,i2c-versatile.yaml
> @@ -0,0 +1,29 @@
> +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/i2c/arm,i2c-versatile.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: I2C Controller on ARM Ltd development platforms
> +
> +maintainers:
> +  - Linus Walleij <linus.walleij@xxxxxxxxxx>
> +
> +allOf:
> +  - $ref: /schemas/i2c/i2c-controller.yaml#
> +
> +properties:
> +  compatible:
> +    const: arm,versatile-i2c
> +
> +  reg:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +
> +unevaluatedProperties: false
> +
> +...
> +
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-versatile.txt b/Documentation/devicetree/bindings/i2c/i2c-versatile.txt
> deleted file mode 100644
> index 361d31c51b6f..000000000000
> --- a/Documentation/devicetree/bindings/i2c/i2c-versatile.txt
> +++ /dev/null
> @@ -1,10 +0,0 @@
> -i2c Controller on ARM Versatile platform:
> -
> -Required properties:
> -- compatible : Must be "arm,versatile-i2c";
> -- reg
> -- #address-cells = <1>;
> -- #size-cells = <0>;
> -
> -Optional properties:
> -- Child nodes conforming to i2c bus binding
> diff --git a/MAINTAINERS b/MAINTAINERS
> index a6d3bd9d2a8d..ecc0907e312a 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1520,7 +1520,7 @@ F:	Documentation/devicetree/bindings/arm/arm,versatile.yaml
>  F:	Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml
>  F:	Documentation/devicetree/bindings/auxdisplay/arm,versatile-lcd.yaml
>  F:	Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
> -F:	Documentation/devicetree/bindings/i2c/i2c-versatile.txt
> +F:	Documentation/devicetree/bindings/i2c/arn,i2c-versatile.yaml

typo:
s/arn/arm/

With that:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>


Best regards,
Krzysztof