Re: [PATCH 1/3] ASoC: wm8940: Remove warning when no plat data

[Lukasz Majewski]

Hi Mark,

> On Mon, Jun 06, 2022 at 06:17:31PM +0200, Lukasz Majewski wrote:
> > > On Mon, Jun 06, 2022 at 05:44:39PM +0200, Lukasz Majewski wrote:  
> 
> > > > The lack of platform data in the contemporary Linux
> > > > shall not be the reason to display warnings to the
> > > > kernel logs.  
> 
> > > Given that the device requires configuration and doesn't appear to
> > > have any other firmware interface support that's rather a strong
> > > statement...  
> 
> > My point is that - similar codec - wm8974 don't display such
> > warnings. (this code was not updated/refactored for a quite long
> > time).  
> 
> Perhaps those drivers are buggy, or those devices lack this specific
> configuration that's being adjusted?  The changelog should at least
> address why the driver was warning about configuration being required
> but it's safe to ignore that.

With v4.4 from which I forward port those changes only the PXA
'stargate2' mach is using this codec.

In this version there is no reference to 'vroi'.

With newest Linux - there is no reference to this codec (even to any
DTS file), so we can assume that from at least v4.4 there is no
reference to platform data for it.


I guess that one can provide the 'vroi' information via DTS nowadays if
required.


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@xxxxxxx

Attachment: pgpUc21minKQx.pgp
Description: OpenPGP digital signature