Re: [PATCH net-next 3/5] net: dsa: realtek: rtl8365mb: correct the max number of ports

From: Luiz Angelo Daros de Luca
Date: Tue Jun 07 2022 - 09:18:13 EST


Em seg., 6 de jun. de 2022 às 10:46, Alvin Šipraga <alvin@xxxxxxx> escreveu:
>
> From: Alvin Šipraga <alsi@xxxxxxxxxxxxxxx>
>
> The maximum number of ports is actually 11, according to two
> observations:
>
> 1. The highest port ID used in the vendor driver is 10. Since port IDs
> are indexed from 0, and since DSA follows the same numbering system,
> this means up to 11 ports are to be presumed.
>
> 2. The registers with port mask fields always amount to a maximum port
> mask of 0x7FF, corresponding to a maximum 11 ports.
> /* valid for all 6-port or less variants */

It makes sense for the family. The 10-ports variants have 0-7 user
ports and ext0,1,2 declared in rtl8367c driver, although no model I
know does use ext2.

Reviewed-by: Luiz Angelo Daros de Luca <luizluca@xxxxxxxxx>