Re: [PATCH 07/36] tty/vt: consolemap: make parameters of inverse_translate() saner

From: Ilpo Järvinen
Date: Tue Jun 07 2022 - 09:32:45 EST


On Tue, 7 Jun 2022, Jiri Slaby wrote:

> - int use_unicode -> bool: it's used as bool at some places already, so
> make it explicit.
> - int glyph -> u16: every caller passes a u16 in. So make it explicit
> too. And remove a negative check from inverse_translate() as it never
> could be negative.
>
> Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>


--
i.