Re: [PATCH 04/10] dt-bindings: arm: freescale: Add fsl,scu-key yaml file

[Rob Herring]

On Tue, Jun 07, 2022 at 01:59:45PM +0300, Abel Vesa wrote:
> This documents separately the key child node of the SCU main node.
> 
> Signed-off-by: Abel Vesa <abel.vesa@xxxxxxx>
> ---
>  .../bindings/arm/freescale/fsl,scu-key.yaml   | 27 +++++++++++++++++++
>  1 file changed, 27 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/arm/freescale/fsl,scu-key.yaml
> 
> diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu-key.yaml b/Documentation/devicetree/bindings/arm/freescale/fsl,scu-key.yaml
> new file mode 100644
> index 000000000000..0b52f2f33bd6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu-key.yaml
> @@ -0,0 +1,27 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/freescale/fsl,scu-key.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: i.MX SCU Client Device Node - SCU key bindings based on SCU Message Protocol
> +
> +maintainers:
> +  - Shawn Guo <shawnguo@xxxxxxxxxx>
> +
> +description: i.MX SCU Client Device Node
> +  Client nodes are maintained as children of the relevant IMX-SCU device node.
> +
> +properties:
> +  compatible:
> +    items:
> +      - const: fsl,imx8qxp-sc-key
> +      - const: fsl,imx-sc-key
> +  linux,keycodes:
> +    description: See Documentation/devicetree/bindings/input/input.yaml

No free form references. Need to add:

allOf:
  - $ref: schemas/input/input.yaml#

And here just:

     linux,keycodes: true


> +
> +additionalProperties: false
> +
> +required:
> +  - compatible
> +  - linux,keycodes
> -- 
> 2.34.3
> 
>