Re: [PATCH] auxdisplay: ht16k33: Use backlight helper

[Miguel Ojeda]

Hi Stephen,

On Tue, Jun 7, 2022 at 8:04 PM Stephen Kitt <steve@xxxxxxx> wrote:
>
> backlight_properties.fb_blank is deprecated. The states it represents
> are handled by other properties; but instead of accessing those
> properties directly, drivers should use the helpers provided by
> backlight.h.
>
> Instead of retrieving the backlight brightness in struct
> backlight_properties manually, and then checking whether the backlight
> should be on at all, use backlight_get_brightness() which does all
> this and insulates this from future changes.

Thanks for the patch! Looks good to me.

There is a functional change in that `BL_CORE_SUSPENDED` is taken into
account with this change, but I assume that is expected. In that case,
it could be good to mention it in the commit message.

Cheers,
Miguel