Re: [PATCH] staging: wfx: Remove redundant NULL check before release_firmware() call
From: Kalle Valo
Date: Wed Jun 08 2022 - 04:52:03 EST
Jérôme Pouiller <jerome.pouiller@xxxxxxxxxx> writes:
> On Monday 6 June 2022 03:42:37 CEST cgel.zte@xxxxxxxxx wrote:
>> From: Minghao Chi <chi.minghao@xxxxxxxxxx>
>>
>> release_firmware() checks for NULL pointers internally so checking
>> before calling it is redundant.
>>
>> Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
>> Signed-off-by: Minghao Chi <chi.minghao@xxxxxxxxxx>
[...]
> Signed-off-by: Jérôme Pouiller <jerome.pouiller@xxxxxxxxxx>
I'll change this to Acked-by, s-o-b should be used only when you are
part of patch distribution:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by
And please edit your quotes, otherwise using patchwork will be painful.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches