Re: [PATCH v2 2/3] usb: phy: Add devm_of_usb_get_phy_by_phandle

[Harsh Agarwal]

On 6/6/2022 4:30 PM, Sergey Shtylyov wrote:
> Hello!
>
> On 6/3/22 8:12 PM, Harsh Agarwal wrote:
>
> > Adding support for devm_of_usb_get_phy_by_phandle which allows
> > us to get PHY phandles of a device declared inside lookup_node.
> >
> > Signed-off-by: Harsh Agarwal <quic_harshq@xxxxxxxxxxx>
> [...]
> > diff --git a/include/linux/usb/phy.h b/include/linux/usb/phy.h
> > index e4de6bc..2581c72 100644
> > --- a/include/linux/usb/phy.h
> > +++ b/include/linux/usb/phy.h
> [...]
> > @@ -249,6 +251,12 @@ static inline struct usb_phy *devm_usb_get_phy_by_phandle(struct device *dev,
> >   	return ERR_PTR(-ENXIO);
> >   }
> >   
> > +extern inline struct usb_phy *devm_of_usb_get_phy_by_phandle(struct device *dev,
>     *extern inline*? :-O
>     Shouldn't it be *static*?
This was a typo. Will change it. Thanks
>   
> > +	const char *phandle, u8 index, struct device_node *lookup_node)
> > +{
> > +	return ERR_PTR(-ENXIO);
> > +}
> > +
> >   static inline struct usb_phy *devm_usb_get_phy_by_node(struct device *dev,
> >   	struct device_node *node, struct notifier_block *nb)
> >   {
> MBR, Sergey