Re: [PATCH] irqchip/ti-sci-intr: Add support for system suspend/resume PM

From: kernel test robot
Date: Wed Jun 08 2022 - 18:10:13 EST


Hi Aswath,

I love your patch! Perhaps something to improve:

[auto build test WARNING on tip/irq/core]
[also build test WARNING on v5.19-rc1 next-20220608]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/intel-lab-lkp/linux/commits/Aswath-Govindraju/irqchip-ti-sci-intr-Add-support-for-system-suspend-resume-PM/20220607-142656
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git cdb4913293897dde0df522ed5789ba016f3b9157
config: arm64-defconfig (https://download.01.org/0day-ci/archive/20220609/202206090635.fkrDWqjX-lkp@xxxxxxxxx/config)
compiler: aarch64-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/c41c5fa0992f5a0a3298d6933ed84349f1f48b58
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Aswath-Govindraju/irqchip-ti-sci-intr-Add-support-for-system-suspend-resume-PM/20220607-142656
git checkout c41c5fa0992f5a0a3298d6933ed84349f1f48b58
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/irqchip/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> drivers/irqchip/irq-ti-sci-intr.c:270: warning: expecting prototype for ti_sci_intr_initialize_mappingg(). Prototype was for ti_sci_intr_initialize_mapping() instead


vim +270 drivers/irqchip/irq-ti-sci-intr.c

264
265 /**
266 * ti_sci_intr_initialize_mappingg - Initialize the out_irq <-> hwirq mapping table
267 * @intr: IRQ domain corresponding to Interrupt Router
268 */
269 static int ti_sci_intr_initialize_mapping(struct ti_sci_intr_irq_domain *intr)
> 270 {
271 int i;
272 int mapping_len = intr->out_irqs->desc->num + intr->out_irqs->desc->num_sec;
273
274 intr->mapping = devm_kzalloc(intr->dev, mapping_len * sizeof(u32), GFP_KERNEL);
275 if (!intr->mapping)
276 return -ENOMEM;
277
278 /* Set all the elements in the array to max value of u32 */
279 for (i = 0; i < mapping_len; i++)
280 intr->mapping[i] = 0xFFFFFFFF;
281
282 return 0;
283 }
284

--
0-DAY CI Kernel Test Service
https://01.org/lkp