Re: [PATCH v8 03/10] dt-bindings: arm: Adds CoreSight TPDM hardware definitions

[Jinlong Mao]

Thank you Rob for the review of the yaml changes.

I will check and address all you comments.

On 6/9/2022 6:01 AM, Rob Herring wrote:
> On Wed, Jun 08, 2022 at 11:46:58PM +0800, Mao Jinlong wrote:
> > Adds new coresight-tpdm.yaml file describing the bindings required
> > to define tpdm in the device trees.
> >
> > Acked-by: Suzuki K Poulose <suzuki.poulose@xxxxxxx>
> > Reviewed-by: Mike Leach <mike.leach@xxxxxxxxxx>
> > Signed-off-by: Tao Zhang <quic_taozha@xxxxxxxxxxx>
> > Signed-off-by: Mao Jinlong <quic_jinlmao@xxxxxxxxxxx>
> > ---
> >   .../bindings/arm/coresight-tpdm.yaml          | 99 +++++++++++++++++++
> qcom,coresight-tpdm.yaml
>
> >   .../devicetree/bindings/arm/coresight.txt     |  7 ++
> This file is going away[1]. I'd just drop the changes to it.
>
> >   MAINTAINERS                                   |  1 +
> >   3 files changed, 107 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/arm/coresight-tpdm.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml b/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml
> > new file mode 100644
> > index 000000000000..14bef4ce4274
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml
> > @@ -0,0 +1,99 @@
> > +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
> > +# Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/arm/coresight-tpdm.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Trace, Profiling and Diagnostics Monitor - TPDM
> > +
> > +description: |
> > +  The TPDM or Monitor serves as data collection component for various dataset
> > +  types specified in the QPMDA spec. It covers Implementation defined ((ImplDef),
> > +  Basic Counts (BC), Tenure Counts (TC), Continuous Multi-Bit (CMB), and Discrete
> > +  Single Bit (DSB). It performs data collection in the data producing clock
> > +  domain and transfers it to the data collection time domain, generally ATB
> > +  clock domain.
> > +
> > +  The primary use case of the TPDM is to collect data from different data
> > +  sources and send it to a TPDA for packetization, timestamping, and funneling.
> > +
> > +maintainers:
> > +  - Mao Jinlong <quic_jinlmao@xxxxxxxxxxx>
> > +  - Tao Zhang <quic_taozha@xxxxxxxxxxx>
> > +
> > +properties:
> > +  $nodename:
> > +    pattern: "^tpdm(@[0-9a-f]+)$"
> blank line
>
> > +  compatible:
> > +    items:
> > +      - const: qcom,coresight-tpdm
> > +      - const: arm,primecell
> You need a 'select' to fix the errors reported. See other primecell
> bindings.
>
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    maxItems: 1
> > +
> > +  clock-names:
> > +    items:
> > +      - const: apb_pclk
> > +
> > +  out-ports:
> > +    description: |
> > +      Output connections from the TPDM to coresight funnle/tpda.
> typo
>
> > +    $ref: /schemas/graph.yaml#/properties/ports
> blank line here.
>
> > +    properties:
> > +      port:
> > +        description: Output connection from the TPDM to coresight
> > +            funnel/tpda.
> s/tpda/TPDA/
>
> > +        $ref: /schemas/graph.yaml#/properties/port
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - clocks
> > +  - clock-names
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  # minimum TPDM definition. TPDM connect to coresight funnel.
> > +  - |
> > +    tpdm@6980000 {
> > +      compatible = "qcom,coresight-tpdm", "arm,primecell";
> > +      reg = <0x6980000 0x1000>;
> > +
> > +      clocks = <&aoss_qmp>;
> > +      clock-names = "apb_pclk";
> > +
> > +      out-ports {
> > +        port {
> > +          tpdm_turing_out_funnel_turing: endpoint {
> > +            remote-endpoint =
> > +              <&funnel_turing_in_tpdm_turing>;
> > +          };
> > +        };
> > +      };
> > +    };
> > +  # minimum TPDM definition. TPDM connect to coresight TPDA.
> > +  - |
> The only difference in the 2 examples is some external phandle. 1
> example is sufficient.
>
> > +    tpdm@684c000 {
> > +      compatible = "qcom,coresight-tpdm", "arm,primecell";
> > +      reg = <0x684c000 0x1000>;
> > +
> > +      clocks = <&aoss_qmp>;
> > +      clock-names = "apb_pclk";
> > +
> > +      out-ports {
> > +        port {
> > +          tpdm_prng_out_tpda_qdss: endpoint {
> > +            remote-endpoint =
> > +              <&tpda_qdss_in_tpdm_prng>;
> > +          };
> > +        };
> > +      };
> > +    };
> > +
> > +...
> Rob
>
> [1] https://lore.kernel.org/all/20220603011933.3277315-1-robh@xxxxxxxxxx/