Re: [PATCH v5 3/4] fat: add renameat2 RENAME_EXCHANGE flag support

[Javier Martinez Canillas]

On 6/10/22 05:17, OGAWA Hirofumi wrote:
> Javier Martinez Canillas <javierm@xxxxxxxxxx> writes:
> 
>>>
>>> Looks like unnecessary complex (and comparing raw i_mode, not S_ISDIR(),
>>> better to change before make dir dirty).  How about this change, it is
>>> only tested slightly though? Can you review and test?
>>>
>>
>> Your change looks good to me and indeed the logic is simpler than in mine.
>>
>> I've also tested it and AFAICT it works correctly as well. Do you plan to
>> squash this or should I respin a new revision of the whole patch-set ? If
>> you want to post it as a follow-up I'm also OK with that.
> 
> Could you merge to your patchset, and re-send?
> 

Sure thing, I'll do that.

-- 
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat