Re: [PATCH 2/3] drm/panel: panel-dsi-cm: Use backlight helpers

[Stephen Kitt]

Hi Sebastian,

On Thu, 9 Jun 2022 23:52:36 +0200, Sebastian Reichel
<sebastian.reichel@xxxxxxxxxxxxx> wrote:
> On Tue, Jun 07, 2022 at 08:20:25PM +0200, Stephen Kitt wrote:
> > diff --git a/drivers/gpu/drm/panel/panel-dsi-cm.c
> > b/drivers/gpu/drm/panel/panel-dsi-cm.c index b58cb064975f..aa36dc6cedd3
> > 100644 --- a/drivers/gpu/drm/panel/panel-dsi-cm.c
> > +++ b/drivers/gpu/drm/panel/panel-dsi-cm.c
> > @@ -86,16 +86,10 @@ static void dsicm_bl_power(struct panel_drv_data
> > *ddata, bool enable) return;
> >  
> >  	if (enable) {
> > -		backlight->props.fb_blank = FB_BLANK_UNBLANK;
> > -		backlight->props.state = ~(BL_CORE_FBBLANK |
> > BL_CORE_SUSPENDED);
> > -		backlight->props.power = FB_BLANK_UNBLANK;
> > +		backlight_enable(backlight);
> >  	} else {
> > -		backlight->props.fb_blank = FB_BLANK_NORMAL;
> > -		backlight->props.power = FB_BLANK_POWERDOWN;
> > -		backlight->props.state |= BL_CORE_FBBLANK |
> > BL_CORE_SUSPENDED;
> > +		backlight_disable(backlight);
> >  	}  
> 
> The brackets can be removed now. Otherwise:

> 
> Reviewed-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx>

Thanks, I’ll wait a little more to see if there are any other reviews of the
patches and then push a v2 with that fix.

Regards,

Stephen

Attachment: pgpzunszIxfyy.pgp
Description: OpenPGP digital signature